Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45787 )
Change subject: soc/intel: Move pch_enable_ioapic() to common code
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45787/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/45787/8/src/soc/intel/common/block/...
PS8, Line 298: lpc_pch_enable_ioapic
its due to pch related code that's why existed since BDW https://github. […]
Another case of "it's always been done that way". It doesn't necessarily make it right though. `ioapic.c` could also work. Also just rename to `pch_ioapic_enable()` ? It does seem to live in the PCH/ICH/southbridge, as the default IOAPIC addresses decode to DMI.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a6afc1da50c8ee5bccda7f5671b516dc31fe023
Gerrit-Change-Number: 45787
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 18:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subi.banik@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment