Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Patch Set 2:
(4 comments)
Welcome to coreboot, and thank you for the patch.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@7 PS2, Line 7: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c Please use the prefix:
superiotool: Add ID for Nuvoton NCT6797D
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@9 PS2, Line 9: + {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART This is in the code, but maybe document, what datasheet you used.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@12 PS2, Line 12: Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Please move this block to the end, and only use Change-Id once.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@18 PS2, Line 18: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool# This line can be removed.