Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Add support to initialize DDR4 Memory
......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39847/20/src/soc/intel/tigerlake/me...
File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/20/src/soc/intel/tigerlake/me...
PS20, Line 330: "
\n
Done
https://review.coreboot.org/c/coreboot/+/39847/20/src/soc/intel/tigerlake/me...
PS20, Line 332: "
\n
Done
https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me...
File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me...
PS21, Line 299: print_spd_info((unsigned char *)blk->spd_array[0]);
: print_spd_info((unsigned char *)blk->spd_array[1]);
: print_spd_info((unsigned char *)blk->spd_array[2]);
: print_spd_info((unsigned char *)blk->spd_array[3]);
Yes that's correct too, I will add the loop.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47a5dcad3ee316871a6103b9d53ef7f6fc88d7d8
Gerrit-Change-Number: 39847
Gerrit-PatchSet: 22
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 22:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Selma Bensaid
selma.bensaid@intel.com
Comment-In-Reply-To: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-MessageType: comment