Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34542 )
Change subject: mb/google/octopus: Add custom SAR values for droid/blorb ......................................................................
Patch Set 5:
(5 comments)
In the future, could you please mark all comments as resolved so that the patch can be merged.
https://review.coreboot.org/c/coreboot/+/34542/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34542/4//COMMIT_MSG@9 PS4, Line 9: droid/blorb needs to use different SAR values than bobba. : Use sku-id to load the SAR values.
Please use the full text width.
Done
https://review.coreboot.org/c/coreboot/+/34542/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/34542/1/src/mainboard/google/octopu... PS1, Line 32: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 || sku_id == 42 || sku_id == 43 || sku_id == 44)
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/34542/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/34542/2/src/mainboard/google/octopu... PS2, Line 32: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 ||
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/34542/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/34542/3/src/mainboard/google/octopu... PS3, Line 17: #include <ec/google/chromeec/ec.h>
We don't need these two header files?
Done
https://review.coreboot.org/c/coreboot/+/34542/3/src/mainboard/google/octopu... PS3, Line 30: return NULL;
Since filename is initialized to NULL, for sku_id not in the checking of line 32 we can just return […]
Done