In the future, could you please mark all comments as resolved so that the patch can be merged.
5 comments:
droid/blorb needs to use different SAR values than bobba.
Use sku-id to load the SAR values.
Please use the full text width.
Done
File src/mainboard/google/octopus/variants/bobba/variant.c:
Patch Set #1, Line 32: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 || sku_id == 42 || sku_id == 43 || sku_id == 44)
line over 96 characters
Done
File src/mainboard/google/octopus/variants/bobba/variant.c:
Patch Set #2, Line 32: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 ||
trailing whitespace
Done
File src/mainboard/google/octopus/variants/bobba/variant.c:
Patch Set #3, Line 17: #include <ec/google/chromeec/ec.h>
We don't need these two header files?
Done
Patch Set #3, Line 30: return NULL;
Since filename is initialized to NULL, for sku_id not in the checking of line 32 we can just return […]
Done
To view, visit change 34542. To unsubscribe, or for help writing mail filters, visit settings.