23 Oct
2019
23 Oct
'19
4:40 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36136 )
Change subject: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36136/11/src/soc/intel/skylake/memm... File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/c/coreboot/+/36136/11/src/soc/intel/skylake/memm... PS11, Line 54: * +--------------------------+ ME Stolen
Actually, if that didn't change over the years, ME UMA is above TOLUD. […]
this is caused by moving the skylake memmap there, we just need to find the correct one out of that three :D (cnl, skl, icl)
--
To view, visit https://review.coreboot.org/c/coreboot/+/36136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If66a00d1320917bc68afb32c19db0e24c6732812
Gerrit-Change-Number: 36136
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:40:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment