Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61500 )
Change subject: mb/google/brya: Lock TPM IRQ pin in brask and brya baseboards ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/gpio.c:
https://review.coreboot.org/c/coreboot/+/61500/comment/ea91eb4e_9f3b2040 PS6, Line 371: PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT),
Is the thinking here that there's no need to set these as LOCK_CONFIG in the early table given they won't get locked until closer to the end of coreboot anyway, so the definitions in the main table will surfice?
Yes, in our gpio_lock_pad() function have anyway discarded the lock_config request coming from early boot stages till ramstage. Hence, adding LOCK_CONFIG here as `early_gpio_table` might not be useful.