Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46142 )
Change subject: mb/google/volteer/variants/volteer2: I2C5 trackpad bus freq 400 kHz
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46142/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46142/3/src/mainboard/google/voltee...
PS3, Line 23: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
I'm not sure we have verified this yet in TGL?
https://review.coreboot.org/c/coreboot/+/46142/3/src/mainboard/google/voltee...
PS3, Line 24: .gspi[0] = {
: .speed_mhz = 1,
: .early_init = 1,
: },
This should go in the baseboard, they all have cr50 on gspi0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0803a74ba9071acf15486ce4038261c1681a92f
Gerrit-Change-Number: 46142
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Oct 2020 15:48:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment