build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32604/3/src/mainboard/apple/macbookair5_2/ma... File src/mainboard/apple/macbookair5_2/mainboard.c:
https://review.coreboot.org/#/c/32604/3/src/mainboard/apple/macbookair5_2/ma... PS3, Line 22: RCBA32(0x38c8) = 0x00002005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32604/3/src/mainboard/apple/macbookair5_2/ma... PS3, Line 29: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); line over 80 characters
https://review.coreboot.org/#/c/32604/3/src/mainboard/apple/macbookair5_2/ma... PS3, Line 29: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); please, no spaces at the start of a line