Attention is currently required from: Raul Rangel, Jon Murphy, Chris Wang, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63717 )
Change subject: mb/google/skyrim: Update SPI settings for skyrim
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/63717/comment/c5dd5b63_f60223e9
PS1, Line 78: EFS_SPI_READ_MODE
PSP doesn't use EFS I thought?
Yes, it doesn't. But both bootblock and PSP verstage will be using speed from EFS to configure.
PSP team is working to not override the speed configuration for Chrome platforms.
https://review.coreboot.org/c/coreboot/+/63717/comment/334f7013_cd00774a
PS1, Line 79: Dual IO (1-1-2)
Check with Johnathan... I would like to use 1-2-2, but not sure the CPLD supports it.
This bug indicates CPLD supports only 1-1-2 - b/225213679#comment18
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63717
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbe4b9f4794f7e883c3819258ede809c3c8922b0
Gerrit-Change-Number: 63717
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 20 Apr 2022 17:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment