Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46665 )
Change subject: sb/intel/lynxpoint: Ensure that `dev->chip_info` is not null
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46665/3/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/serialio.c:
https://review.coreboot.org/c/coreboot/+/46665/3/src/southbridge/intel/lynxp...
PS3, Line 134: struct southbridge_intel_lynxpoint_config *config = config_of(dev);
Or bail out if it's NULL?
I guess it's also an option, but can't readily test it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a01b898c3e62423f27c2940b5f875b73e36950
Gerrit-Change-Number: 46665
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 10:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment