[coreboot-gerrit] Change in coreboot[master]: security: tcg-2.0: Ignore data payload for errors, fix Cr50 boot mode

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41100 )

Change subject: security: tcg-2.0: Ignore data payload for errors, fix Cr50 boot mode
......................................................................

security: tcg-2.0: Ignore data payload for errors, fix Cr50 boot mode

This patch improves the response buffer handling for TPM 2.0. Previously
we would allow any command to return no payload, but if there was a
payload we would always try to unmarshal it according to the normal
success response. This was sort of relying on the fact that the TPM
usually returns no additional data after the header for error responses,
but in practice that is not always true. It also means that commands
without a response payload accidentally work by default even though we
did not explicitly add unmarshallig support for them, which seems
undesirable. Adding explicit unmarshalling support for TPM2_SelfTest
which was only supported through this loophole before.

This patch changes the behavior to always accept any amount of payload
data for error responses but not unmarshal any of it. None of our use
cases actually care about payload data for errors, so it seems safer to
not even try to interpret it. For success responses, on the other hand,
we always require support for the command to be explicitly added.

This fixes a problem with the Cr50 GET_BOOT_MODE command where an error
response would only return the subcommand code but no data after that.
Also add support for a second, slightly different NO_SUCH_COMMAND error
code that was added in Cr50 recently.

Signed-off-by: Julius Werner 
Change-Id: Ib85032d85482d5484180be6fd105f2467f393cd2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41100
Reviewed-by: Vadim Bendebury 
Reviewed-by: Andrey Pronin 
Tested-by: build bot (Jenkins) 
---
M src/security/tpm/tss/tcg-2.0/tss_marshaling.c
M src/security/tpm/tss/vendor/cr50/cr50.c
M src/security/tpm/tss/vendor/cr50/cr50.h
3 files changed, 17 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Vadim Bendebury: Looks good to me, approved
  Andrey Pronin: Looks good to me, but someone else must approve

diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
index a229dd1..eff1acd 100644
--- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
+++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
@@ -587,17 +587,23 @@
    if (rc != 0)
    	return NULL;

-	if (ibuf_remaining(ib) == 0) {
-		if (tpm2_static_resp.hdr.tpm_size != ibuf_nr_read(ib))
-			printk(BIOS_ERR,
-			       "%s: size mismatch in response to command %#x\n",
-			       __func__, command);
-		return &tpm2_static_resp;
+	if (ibuf_capacity(ib) != tpm2_static_resp.hdr.tpm_size) {
+		printk(BIOS_ERR,
+		       "%s: size mismatch in response to command %#x\n",
+		       __func__, command);
+		return NULL;
    }

+	/* On errors, we're not sure what the TPM is returning. None of the
+	   commands we use actually expect useful data payloads for errors, so
+	   just ignore any data after the header. */
+	if (tpm2_static_resp.hdr.tpm_code != TPM2_RC_SUCCESS)
+		return &tpm2_static_resp;
+
    switch (command) {
    case TPM2_Startup:
    case TPM2_Shutdown:
+	case TPM2_SelfTest:
    	break;

case TPM2_GetCapability:
diff --git a/src/security/tpm/tss/vendor/cr50/cr50.c b/src/security/tpm/tss/vendor/cr50/cr50.c
index ae2f7c2..d7bf48d 100644
--- a/src/security/tpm/tss/vendor/cr50/cr50.c
+++ b/src/security/tpm/tss/vendor/cr50/cr50.c
@@ -89,7 +89,8 @@
    	return TPM_E_MUST_REBOOT;
    }

-	if (response->hdr.tpm_code == VENDOR_RC_NO_SUCH_COMMAND) {
+	if (response->hdr.tpm_code == VENDOR_RC_NO_SUCH_COMMAND ||
+	    response->hdr.tpm_code == VENDOR_RC_NO_SUCH_SUBCOMMAND) {
    	/*
    	 * Explicitly inform caller when command is not supported
    	 */
@@ -119,7 +120,8 @@
    if (!response)
    	return TPM_E_IOERROR;

-	if (response->hdr.tpm_code == VENDOR_RC_NO_SUCH_COMMAND)
+	if (response->hdr.tpm_code == VENDOR_RC_NO_SUCH_COMMAND ||
+	    response->hdr.tpm_code == VENDOR_RC_NO_SUCH_SUBCOMMAND)
    	/* Explicitly inform caller when command is not supported */
    	return TPM_E_NO_SUCH_COMMAND;

diff --git a/src/security/tpm/tss/vendor/cr50/cr50.h b/src/security/tpm/tss/vendor/cr50/cr50.h
index 0f91732..e3146a4 100644
--- a/src/security/tpm/tss/vendor/cr50/cr50.h
+++ b/src/security/tpm/tss/vendor/cr50/cr50.h
@@ -21,6 +21,7 @@
 #define VENDOR_RC_ERR              0x00000500
 enum cr50_vendor_rc {
    VENDOR_RC_INTERNAL_ERROR = (VENDOR_RC_ERR | 6),
+	VENDOR_RC_NO_SUCH_SUBCOMMAND = (VENDOR_RC_ERR | 8),
    VENDOR_RC_NO_SUCH_COMMAND = (VENDOR_RC_ERR | 127),
 };