Hello Daisuke Nojiri, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31585
to look at the new patch set (#2).
Change subject: ec/google/chromeec: fix the error status handling ......................................................................
ec/google/chromeec: fix the error status handling
Various instances of google_chromeec_command() can return non-zero number (both positive and negative) to indicate error, which causes confusion for the caller. This patch attempts to address the issue by using only negative number for errors.
In addition, the patch modifies some callers of google_chromeec_command() such as cbi_get_uint32() and cbi_get_string() so they check the return error status the same way as the rest of the callers.
BUG=b:123676982,chromium:935038 BRANCH=kukui TEST=build with kukui/flapjack configurations Signed-off-by: YH Lin yueherngl@google.com Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c --- M src/ec/google/chromeec/crosec_proto.c M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_i2c.c M src/ec/google/chromeec/ec_lpc.c 4 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/31585/2