Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
I don't understand using HATCH as a model, when the boards listed in Kconfig.name there clearly select more than just the baseboard -- they select overrides, audio drivers, etc.
Forget hatch and have a look at google/poppy.
Having each board select the correct SoC and having everything else in Kconfig is the cleanest way to do it; otherwise, I'm defining two SoC-specific baseboards, each of which selects the LIBREM_CNL baseboard, all just to not have the SoC selected in Kconfig.name
Well, the cleanest way IMO *is* having two SoC-specific baseboards or even having another Kconfig per variant (board/variant/*/Kconfig). Are you 100% sure it will only be the SoC? What when you realize you need to override another Kconfig? Do you add that to Kconfig.name, too, then?
I generally agree with Michael's sentiment. But placing selects in `Kconfig.name` is already common practice for a year or so or maybe more. If somebody wants to stop that, this is not the right place to discuss it.
I'm not completely against having a select in Kconfig.name, even when that would be the best - selecting the baseboard and a board variant (if done right, only the latter) should be ok.
Just think about this once again, please. I won't block this, if you all agree that this needs more general discussion.