Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )
Change subject: drivers/smmstore: Implement SMMSTORE version 2
......................................................................
Patch Set 22:
Patch Set 22:
Patch Set 22:
Patch Set 22: Code-Review+1
(1 comment)
Very cool stuff. Works out-of-the-box with patched TianoCore.
can you provide a branch/commit and platform on which you're able to verify this with this current patchset?
Recently I have used this commit:
https://github.com/9elements/edk2-1/commit/59b3af6d0340ed01471018d68c693cd1d...
and built coreboot with UEFI payload and this patch. Worked perfectly on Dell OptiPlex 9010 SFF (although you cannot use TianoCore debug build, because it will cause some timing issues with SMMSTORE related SMIs - some FVB write/read protocol calls gave success, some were aborted).
I've tried this on the Asrock B85M Pro4, and something is definitely being saved: the language setting. I think it's the simplest thing one can use to verify persistence. I've also been able to add a new boot entry and it will be saved.
Other settings such as changing the console output mode do not seem to persist across reboots, but I've no idea if they're supposed to work in the first place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e49d184135710f3e6dd1ad3bed95de950fe057
Gerrit-Change-Number: 40520
Gerrit-PatchSet: 22
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:28:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment