Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port ......................................................................
Patch Set 26:
(50 comments)
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... PS18, Line 78: io 0x60 = 0x0a30
just wondering: does accessing these ranges work? I'm not so familiar with how baytrail sets up LPC […]
I could just remove it, the environment controller is not actually needed in the devices built around this board, but it has a fan header on the board.
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... File src/mainboard/bostentech/gbyt4/gpio.c:
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 7: GPIO_FUNC(2, PULL_UP, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_UP, 20K),
I'd say these shouldn't be pulling anything
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 19: GPIO_FUNC(1, PULL_DOWN, 20K),
I'd try removing the pull
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 24: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
I'd say these don't need pull down
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 40: GPIO_FUNC(2, PULL_DOWN, 20K),
I'd say this doesn't need a pull
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 41: GPIO_FUNC(1, PULL_UP, 20K),
SATA LED, does it work as intended with this pull?
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 41: : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
These are PCIe clock request pins. I'd drop the pull and see if the Ethernet NICs still work.
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 46: GPIO_FUNC(0, PULL_UP, 20K),
SD-related, probably NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 47: GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K), : GPIO_FUNC(2, PULL_DOWN, 20K),
HDA-related, if there's no audio on your board then this should be NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 55: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
MMC-related, unused?
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 66: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
SD2, unused
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 72: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
SD3, unused
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 81: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
LPC pins, use GPIO_FUNC1
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 86: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
More LPC clock stuff, they can also use GPIO_FUNC1
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 89: GPIO_FUNC(1, PULL_UP, 20K),
SERIRQ, probably doesn't need pullups
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 90: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
SMBus, should be GPIO_FUNC1
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 93: GPIO_FUNC(1, PULL_DOWN, 20K)
Speaker
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 94: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
Strap pins, probably unused
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 96: GPIO_FUNC(1, PULL_UP, 20K),
Integrated UART TXD, likely NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 97: GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K),
Probably NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 100: GPIO_FUNC(1, PULL_DOWN, 20K),
Integrated UART RXD, probably NC as well
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 101: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
I2S, pretty sure it's NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 105: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
SPI controller for dedicated hardware, not for the SPI flash so NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 109: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
UART1, most likely not connected
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 113: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
UART2, most likely NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 117: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
I2C ports for touchpad/touchscreen, most likely NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 117: GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(2, PULL_UP, 20K), : GPIO_FUNC(0, PULL_UP, 20K), : GPIO_FUNC(0, PULL_UP, 20K),
I2C ports, unused
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 133: GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DISABLE, 20K),
PWM pins, probably unused because they are wired as GPIOs
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 135: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
Platform clocks, most likely NC. […]
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 147: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K),
This looks wrong, function 1 is reserved for these two
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 146: GPIO_FUNC(0, PULL_UP, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(0, PULL_UP, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K),
I'd say these are all NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 151: GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC1 (PMC_SUSCLK1)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 152: GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K),
Most likely NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 154: GPIO_FUNC(0, PULL_DISABLE, 20K), : GPIO_FUNC(0, PULL_DISABLE, 20K),
NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 156: GPIO_FUNC(0, PULL_UP, 20K),
Probably NC
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 157: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (SUSPWRDNACK)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 158: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (SUSCLK)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 159: GPIO_FUNC(0, PULL_DOWN, 20K),
NC, probably?
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 160: GPIO_FUNC(2, PULL_DISABLE, 20K),
GPIO_FUNC2 (USB_ULPI_RST#)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 161: GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC0 (PMC_WAKE_PCIE[0])
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 163: GPIO_FUNC(1, PULL_UP, 20K),
NC, most likely
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 164: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (PMC_SUS_STAT#)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 165: GPIO_FUNC(0, PULL_UP, 20K), : GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC0 (USB_OC0 and USB_OC1)
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 167: GPIO_FUNC(1, PULL_UP, 20K),
NC?
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 168: GPIO_FUNC(0, PULL_DISABLE, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_DOWN, 20K), : GPIO_FUNC(0, PULL_UP, 20K), : GPIO_FUNC(2, PULL_UP, 20K), : GPIO_FUNC(0, PULL_DISABLE, 20K), : GPIO_FUNC(0, PULL_DISABLE, 20K),
XDP stuff, most likely NC?
Done
https://review.coreboot.org/c/coreboot/+/43087/5/src/mainboard/bostentech/gb... PS5, Line 177: GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_DISABLE, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K), : GPIO_FUNC(1, PULL_UP, 20K), : GPIO_FUNC(1, PULL_DOWN, 20K),
This is most likely NC as well, it's USB ULPI and would only be used in tablets, if at all... […]
Done
https://review.coreboot.org/c/coreboot/+/43087/25/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43087/25/src/mainboard/bostentech/g... PS25, Line 123: #if CONFIG(VGA_ROM_RUN)
I am not sure how to handle the x86emu stuff above without using the preprocessor.
Done
https://review.coreboot.org/c/coreboot/+/43087/3/src/mainboard/bostentech/gb... File src/mainboard/bostentech/gbyt4/romstage.c:
https://review.coreboot.org/c/coreboot/+/43087/3/src/mainboard/bostentech/gb... PS3, Line 21:
More correctly it does boot if it's here, but there is serial output only after romstage, and it tak […]
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/cmo... File src/mainboard/unk/gbyt4/cmos.layout:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/cmo... PS1, Line 55: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3
Should it be renamed to BayTrail or dropped entirely?
Done (dropped entries)
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... File src/mainboard/unk/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... PS1, Line 69: off
From the data sheet it looks like it's a different SPI controller not the same as the flashchip is o […]
Done