Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32118 )
Change subject: mb/google/sarien/variants/sarien: Update thermal configuration for DPTF
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32118/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/32118/1/src/mainboard/google/sarien/variants...
PS1, Line 45: 15
Because Chromebook use DPTF passive policy 1, so don't need set PL2 25W to dynamic to TDP 15W, thank […]
Did you check above mentioned BUG:b:122343940 ? You only requested some time back to change it from 15W to 25W. And now you are changing it back to 15W on this bug c#1.
Also, did you get chance to check the performance benchmark impact due to this your new change from 25W to 15W ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64844b84891dc3ab7abe9378cdca5dcf57b3e433
Gerrit-Change-Number: 32118
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Apr 2019 08:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Gerrit-MessageType: comment