Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/#/c/32604/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32604/5//COMMIT_MSG@12 PS5, Line 12: - Linux : - GRUB, SeaBIOS
What versions?
Devuan ascii, kernel 4.9.0 GRUB 2.02 SeaBIOS 1.12.1
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc... File src/mainboard/apple/macbookair5_2/Kconfig:
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc... PS1, Line 16: LVDS
eDP
Done
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc... PS1, Line 35: config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID : hex : default 0x7270 : : config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID : hex : default 0x8086
Please remove
Done
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc... PS1, Line 45: 60
Yes. In 4,2 schematics it's also GPIO28.
Done
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/de... File src/mainboard/apple/macbookair5_2/devicetree.cb:
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/de... PS1, Line 53: subsystemid 0x8086 0x7270
These lines can be removed when inheriting the subsystemid
Done
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/de... PS1, Line 59: end
Please move to the previous line
Done