Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34664 )
Change subject: lib/stage_cache: Refactor Kconfig options ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig@264 PS3, Line 264: "Cache stages in CBMEM"
If this is a user-selectable option and user decides to set it to N and NO_STAGE_CACHE is n, what is […]
Disabled cache, there are empty stubs in stage_cache.h. The case of your first comment.
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig@1164 PS3, Line 1164: HAVE_ACPI_RESUME
If you add || !RELOCATABLE_RAMSTAGE here then you won't have to add it to each type of {TSEG,CBMEM}_ […]
True, but the 'depends on' was there already for (new) TSEG_STAGE_CACHE.
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h File src/include/stage_cache.h:
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h@3... PS3, Line 35: CONFIG(TSEG_STAGE_CACHE) || CONFIG(CBMEM_STAGE_CACHE)
Why not !CONFIG(NO_STAGE_CACHE)? Is that because NO_STAGE_CACHE could be N and both these configs ca […]
Exactly, CBMEM_STAGE_CACHE is user settable.
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h@5... PS3, Line 54: external
Do you intend to update all references of external stage cache to TSEG stage cache as well?
Well the API is not restricted to TSEG. Just that at the moment we do not provide other choices. So not here.