[coreboot-gerrit] Change in coreboot[master]: drivers/genesyslogic/gl9755: Add driver for Genesys Logic GL9755

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45062 )

Change subject: drivers/genesyslogic/gl9755: Add driver for Genesys Logic GL9755
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl... 
File src/drivers/genesyslogic/gl9755/Kconfig:

https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl... 
PS5, Line 3: 
Maybe a line of help text here? Maybe something similar to your website text?
```GL9755 is a PCI Express Rev. 2.1 compliant card reader controller which integrates PCI Express PHY, UHS-II PHY, memory card access interface, regulators (3.3V-to-1.8V and 3.3V-to-1.2V) and card power switch.```

https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl... 
File src/drivers/genesyslogic/gl9755/gl9755.c:

https://review.coreboot.org/c/coreboot/+/45062/5/src/drivers/genesyslogic/gl... 
PS5, Line 15: 	printk(BIOS_INFO, "GL9755: init\n");
Does this line add much value? If you want to see if the device is being initialized, you can follow the resource allocator output and look for VID/DID.