Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36548 )
Change subject: drivers/intel/fsp2_0: Use strip_quotes for cbfs filenames
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36548/1/src/drivers/intel/fsp2_0/Ma...
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36548/1/src/drivers/intel/fsp2_0/Ma...
PS1, Line 47: cbfs-files-$(CONFIG_FSP_CAR) += $(call strip_quotes,$(CONFIG_FSP_T_CBFS))
A pattern we sometimes use to reduce the number of instances of strip_quotes calls is […]
I updated the patchset with reduced strip_quotes calls. This looks a lot better. Thanks for the suggestion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14267502cfab5308d3874a0c0fd18a71b08bb9f8
Gerrit-Change-Number: 36548
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 13:40:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment