Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support
......................................................................
Patch Set 48: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@357
PS48, Line 357: abiility
why is a typo being added?
https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@758
PS48, Line 758: } else
Code style says that, since the if-branch needs braces, the else-branch should use braces as well:
https://doc.coreboot.org/coding_style.html
https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@1040
PS48, Line 1040: // make sure there is enough room for the SMM descriptor
nit: comment style should be consistent
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 48
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Wed, 29 Jan 2020 23:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment