Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon...
File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon...
PS11, Line 210: select ALWAYS_LOAD_OPROM
i'm asking if you can submit your base cl so i can submit this cl too.
marking this resolved based on merit here
Hmmm, this worked. Subrata, did you intentionally mark this as "Resolved"
while we are discussing it?
ALWAYS_LOAD_OPROM is only needed if you wish to load the OpRom even if it
*won't* be executed. The OS can do this by itself for cards that have an actual
ROM. The VBT is an Intel concept. Intel's IGD does not have a physical ROM,
so the VBT/VBIOS has to be loaded from CBFS (what the OS drivers usually
can't do).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebde69e38defbe3321eb5e5bbd632c209ae2cd8
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 24 Jul 2019 06:25:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment