Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )
Change subject: src: Remove unused 'include <timestamp.h>'
......................................................................
Patch Set 7:
(1 comment)
No idea what the intention was wrt. `include/timestamp.h` vs the commonlib
one. I'd say the indirect include is ok?
https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG@7
PS7, Line 7: src: Remove unused 'include <timestamp.h>'
Also `replace`? and it's not unused if you need to replace it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Gerrit-Change-Number: 35123
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 11:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment