Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 156: GPP_D3
Yes, this is supposed to be wake line. Let me check it.
Done
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 188: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF2), : /* D20 : WWAN_WLAN_COEX2 */ : PAD_CFG_NF(GPP_D20, NONE, DEEP, NF2), : /* D21 : WWAN_WLAN_COEX3 */ : PAD_CFG_NF(GPP_D21, NONE, DEEP, NF1),
Interesting. It would be good to check with Intel on this. […]
Aamir, Can you or someone from Intel help to address this comment?
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 330: GPP_H19
True, I have to add a device tree object under XHCI for Bluetooth.
Done here - https://review.coreboot.org/c/coreboot/+/39446
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 385: PAD_CFG_NF(GPD9, NONE, DEEP, NF1),
No. I don't think we ever use it. […]
Done
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 6: 00.0
True, I am setting it up here because Dee uses a different PCIe WiFi part. […]
Ack