Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42074 )
Change subject: soc/amd/common: Refactor SMBus base arguments
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s...
File src/soc/amd/common/block/smbus/sm.c:
https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s...
PS17, Line 28: res = find_resource(pbus->dev, 0x90);
I saw 0:14.0 PCI config register 0x90 defined in SB600 and SB700, dropped from SB800 documentation.
just had a look and that register is neither defined in the stoneyridge bkdg not in the picasso ppr. as far as i've looked this function seems to be rather wrong to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e0ebd7609c5c83d0e443ffba74dae68017d3ebc
Gerrit-Change-Number: 42074
Gerrit-PatchSet: 18
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 00:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment