Attention is currently required from: Arthur Heymans, Felix Singer, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60404 )
Change subject: soc/intel/common/cse: Helper function to set D0I3 for all HECI devices
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/60404/comment/1a932f3e_5f12263a
PS2, Line 17: /* SoC callback to set D0I3 for all HECI devices */
: __weak void soc_heci_set_d0i3(void) { /* no-op */ }
Is the weak empty function meaningful on most SoC's or should it be implemented by all and this […]
Yes, In my mind still that __weak declaration was running hence wrongly commented about guarding the declaration. Abandon this CL now as I have move the declaration into CB:60405
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60404
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9eb573be096928ccd6cd05b672ec022f5840059
Gerrit-Change-Number: 60404
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 28 Dec 2021 10:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment