5 Nov
2019
5 Nov
'19
5:16 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc@1... PS2, Line 167: >
-E -o filename works as well, and might have advantages wrt atomic updates (not sure).
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/35602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea9e1a66409659b47dfa3945c63fa1a7874de1ca
Gerrit-Change-Number: 35602
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Nov 2019 17:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment