Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33407 )
Change subject: nb/intel/pineview: Remove dead code in switch
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33407/1/src/northbridge/intel/pinev...
File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/33407/1/src/northbridge/intel/pinev...
PS1, Line 469: break
This and the other 'break' on the following case block can be omitted (just like you did on the code […]
Ack
https://review.coreboot.org/c/coreboot/+/33407/1/src/northbridge/intel/pinev...
PS1, Line 490: if (freq == MEM_CLOCK_800MHz) {
Nope. […]
Ok, let's leave it as-is then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfb9cc27dd8718f627d15ba92a9c74c51c2c1c2d
Gerrit-Change-Number: 33407
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jul 2019 20:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment