Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 )
Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC
......................................................................
Patch Set 5:
(2 comments)
my other comments from the first patch set are already addressed, but those two remain
https://review.coreboot.org/#/c/29475/5/src/drivers/i2c/nct7802y/nct7802y_fa...
File src/drivers/i2c/nct7802y/nct7802y_fan.c:
https://review.coreboot.org/#/c/29475/5/src/drivers/i2c/nct7802y/nct7802y_fa...
PS5, Line 68: div
did you check what I commented on this line in patchset 1?
https://review.coreboot.org/#/c/29475/5/src/drivers/i2c/nct7802y/nct7802y_fa...
PS5, Line 82: return;
I'd print a warning in this case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76
Gerrit-Change-Number: 29475
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Feb 2019 09:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
