Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30891 )
Change subject: console: Change BOOTBLOCK_CONSOLE default to `y` ......................................................................
Patch Set 3:
(1 comment)
Can we make a ruling that BOOTBLOCK_CONSOLE=n will also remove verstage console?
Technically, that's easy to do, just set its default accordingly. We could also enforce it by adding an `if BOOTBLOCK_CONSOLE` to its prompt. Then the default should also trigger with an old config.
I would welcome the default change. Not sure about enforcing it.
I think we should ask ourselves why we have this option in the first place. I don't think it's really meant primarily as a user control... because I don't really see how that would be that useful (when do you really ever want output from romstage but not from the bootblock?), and if we wanted that we should probably have a more consistent set of options to decide it for each stage.
IIRC this was actually introduced to work around problems on platforms where the bootblock console *couldn't* be used for some reason, and for those it must be selectable by the mainboard/SoC to make sense. If we don't have that case anymore, we should probably get rid of the option entirely instead. If we do, we could turn it around to CONFIG_NO_BOOTBLOCK_CONSOLE that can be selected by a handful of mainboards/SoCs where necessary. (I seem to recall it was necessary for Exynos5420 but don't really have time to dig right now. There was also recently some consideration to use it on the new MediaTek 8183 because it doesn't actually load the bootblock from SPI and thus comes with some very tough size restrictions for the bootblock alone. We didn't end up using it for now but it might come up again as we continue bringing up the board. For both of those cases, restricting the option to affect only the bootblock and not the verstage is the desired behavior.)
https://review.coreboot.org/#/c/30891/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30891/3//COMMIT_MSG@13 PS3, Line 13: samsung/exynos5420 IIRC this was intentional, because there was some bug on 5420 that made it hang when you tried to use the UART that early and we never bothered to track it down. But I'll admit I'm too lazy to dig it out and test right now too.