Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40296 )
Change subject: soc/amd/picasso: Add common PSP support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40296/3/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40296/3/src/soc/amd/picasso/Kconfig...
PS3, Line 50: select SOC_AMD_COMMON_BLOCK_PSP_GEN2
Huh, that selecting this doesn't cause any linker errors about `soc_fill_smm_trig_info` and `soc_fil […]
soc/amd/picasso is currently not boot tested by upstream Jenkins, since mb/amd/mandolin hasn't landed yet; that depends on some blobs being upstreamed and the mainboard code cleaned up. I did a local build&boot test on this whole patch train though; didn't try every single commit though. Had a quick look into this and yes, this commit likely needs to be swapped with the next one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I322fd11a867a817375ff38a008219f9236c4f2ea
Gerrit-Change-Number: 40296
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Apr 2020 12:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment