[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Drop use of SPD cache for puff-based variants

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47899 )

Change subject: mb/google/hatch: Drop use of SPD cache for puff-based variants
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47899/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47899/1//COMMIT_MSG@19 
PS1, Line 19: Test: build/boot WYVERN variant, check boot times via cbmem:
            : w/SPD caching: ~722 ms
            : w/FSP reading: ~627 ms
> Hi Matt, Do you see the different between cold reboot and warm reboot?
>
> With SPD cache
> 1265891 Cold reboot
> 1062252 warm reset
>
> With this patch
> 1284142 Cold reboot
> 1056183 warm reset

on a google/puff variant (wyvern), I'm seeing:

with SPD cache
cold: 13,059,672
warm: 904,647

with patch
cold: 13,214,845
warm: 897,934

for some reason, a cold reboot seems to always result in MRC cache needing to be updated. Need to look into that.