View Change
1 comment:
Commit Message:
Patch Set #1, Line 19:
Test: build/boot WYVERN variant, check boot times via cbmem:
w/SPD caching: ~722 ms
w/FSP reading: ~627 ms
Hi Matt, Do you see the different between cold reboot and warm reboot?
With SPD cache
1265891 Cold reboot
1062252 warm reset
With this patch
1284142 Cold reboot
1056183 warm reset
on a google/puff variant (wyvern), I'm seeing:
with SPD cache
cold: 13,059,672
warm: 904,647
with patch
cold: 13,214,845
warm: 897,934
for some reason, a cold reboot seems to always result in MRC cache needing to be updated. Need to look into that.
To view, visit change 47899. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e4db9ba9fdb0fa9fafb2645819b111d381b5756
Gerrit-Change-Number: 47899
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen@intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Mon, 30 Nov 2020 07:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Chen <jamie.chen@intel.corp-partner.google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment