Attention is currently required from: Lance Zhao, Nico Huber, Johnny Lin, Angel Pons, Patrick Rudolph.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35919 )
Change subject: inteltool: Allow to set cores range for MSRs dump
......................................................................
Patch Set 16:
(1 comment)
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/35919/comment/551974bb_b701480b
PS13, Line 666: if (!dump_coremsrs) {
It seems to me that this check is unnecessary and there is no point in it. […]
Do you agree with this? Resolved?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a037cf7ac270d2b51d6e453334c358ff47b4105
Gerrit-Change-Number: 35919
Gerrit-PatchSet: 16
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 23 Jul 2021 09:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment