Attention is currently required from: Reka Norman, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64209 )
Change subject: mb/google/nissa/var/nivviks: Disable pen garage based on fw_config
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
If we leave the CL as is, then the SD pins won't be enabled on nivviks. […]
yes, for now. before we improve the gpio merge :p We can do this later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c3f5403e0f11443ad3647b8c4ae624f0b88a111
Gerrit-Change-Number: 64209
Gerrit-PatchSet: 8
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 May 2022 00:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment