Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41877 )
Change subject: Add Kconfig option for ACPI S3 support ......................................................................
Patch Set 1:
Michał, Krystian, once working, I guess this might also be interesting for the PC Engines APU boards.
``` $ more pcengines/apu1/4.11-2657-gbc41ccf12c/2020-05-11T06_23_33Z/coreboot_console.txt […]
BS: BS_POST_DEVICE run times (exec / console): 0 / 4 ms
APIC 00: ** Enter AmdInitLate [00020004] ASSERTION ERROR: file 'src/vendorcode/amd/agesa/f14/Proc/Common/CommonReturns.c', line 174 ASSERTION ERROR: file 'src/vendorcode/amd/agesa/f14/Proc/CPU/cpuGeneralServices.c', line 817 ASSERTION ERROR: file 'src/vendorcode/amd/agesa/f14/Proc/Common/CommonReturns.c', line 174 ASSERTION ERROR: file 'src/vendorcode/amd/agesa/f14/Proc/CPU/cpuGeneralServices.c', line 817 SB800: sb_Late_Post AmdInitLate() returned AGESA_SUCCESS APIC 00: Heap in SystemMem (4) at 0x10000014 APIC 00: ** Exit AmdInitLate [00020004]
APIC 00: ** Enter AmdS3Save [0002000b] Manufacturer: c2 SF: Detected c2 2015 with sector size 0x1000, total 0x200000 SF: Successfully erased 4096 bytes @ 0xffff1000 Manufacturer: c2 SF: Detected c2 2015 with sector size 0x1000, total 0x200000 SF: Successfully erased 4096 bytes @ 0xffff0000 AmdS3Save() returned AGESA_SUCCESS APIC 00: Heap in SystemMem (4) at 0x10000014 APIC 00: ** Exit AmdS3Save [0002000b] BS: BS_POST_DEVICE exit times (exec / console): 109 / 86 ms […] ```