Attention is currently required from: Patrick Rudolph, Angel Pons, Subrata Banik, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48658 )
Change subject: soc/intel/*: Add TPM decode range to soc_get_fixed_mmio_ranges()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I was invited late, so no idea if this was debated yet:
I don't think the code around soc_get_fixed_mmio_ranges()
is worth saving. The idea to use PCH_PRESERVED_BASE_*
there seems completely wrong and any comprehensive list
(like tried on APL) would kind of compete with resource
lists in our devicetree.
So far, we couldn't see any device that needs the (most
likely untested) mechanism around LGMR in soc/intel/. If
nobody finds one, I would prefer to just drop the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f2257b55a712b936763cfd289c2c4b1633e8049
Gerrit-Change-Number: 48658
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 14 Jan 2021 22:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment