[coreboot-gerrit] [XS] Change in coreboot[main]: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option

[Nico Huber (Code Review)]

Attention is currently required from: Cliff Huang, Felix Held, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak.

Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82642/comment/505bae7b_5a7bb067?usp... :
PS1, Line 7: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
Why?

I actually don't "remember" why I added it. However given that there
are always voices against double negatives, it seems very likely that
was the concern here. The original use was
```
if (CONFIG(ACPI_HAVE_PCAT_8259))
```
I'd like to keep that.

The other cases actually seem better as they are, too, at least to me.
A syntactical `!` seems more clear than a `NO` hidden in an identifier.