Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47719 )
Change subject: mb/google/zork: Remove 50ms WIFI delay ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 213: mdelay(50);
Not a bad idea, however I don't think we're anywhere near the edge now. […]
The time between the end of bootblock to the start of ramstage is 224ms. Since we only need 50ms, I think we're good with no timer.
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 203: * - Deassert WIFI_AUX_RESET_L in mainboard_configure_gpios
"WIFI_AUX_RESET_L gets deasserted later in mainboard_configure_gpios in ramstage" maybe?
Done
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 276: __weak void variant_pcie_gpio_configure(void)
out of scope for this patch, but i'd like this function to be renamed to variant_pcie_early_gpio_con […]
Tracked in b/173626527