[coreboot-gerrit] Change in ...coreboot[master]: intel/apollolake: Add fixed resources for VTd to system resources

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30991 )

Change subject: intel/apollolake: Add fixed resources for VTd to system resources
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/30991/6/src/soc/intel/apollolake/systemagent... 
File src/soc/intel/apollolake/systemagent.c:

https://review.coreboot.org/#/c/30991/6/src/soc/intel/apollolake/systemagent... 
PS6, Line 53: 			      (MCHBAR32(GFXVTBAR) & VTBAR_MASK) / KiB,
> Both BARs are 64-bit registers.

Yes, and we have just an "unsigned long" to pass to the mmio_resource(). Do you want to me to make sure that the upper 32 bits are cleared? Or is there a way to report a 64-bit (reduced by 10 bit due to KiB granularity) value?