[coreboot-gerrit] Change in coreboot[master]: drivers/intel/usb4: Add driver for USB4 retimer device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )

Change subject: drivers/intel/usb4: Add driver for USB4 retimer device
......................................................................

Patch Set 13: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
PS13, Line 31: 0x07
> 0x03

My bad. 0x07 is correct. Bit 0 indicates additional functions are supported and then each bit after that indicates support for the additional function.

https://review.coreboot.org/c/coreboot/+/44918/13/src/drivers/intel/usb4/ret... 
PS13, Line 39: 0x07
> 0x03?

Same as above.