Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for version 3.2
......................................................................
Patch Set 5:
Patch Set 1:
(1 comment)
Sorry for the revert. Please, split out the functional
changes (e.g. the cpuid stuff around core/thread count)
into their own patch (it's not related to the SMBIOS
update, is it?). This change does a lot of things, and
I haven't spotted anything yet that is *required* for
SMBIOS 3.2.
Nico,
From the 3.2 spec, core counts and thread counts don't seem to be optional.
The newly added procedure is populating them to comply to one of your previous comment:
" please don't add fields without giving them a reasonable value"
I can remove it from this patch if you require it and set the values to 0. Because the count generated by the code before this upgrade was not accurate, at least not on the GKL Sparky platform.
Regards,
Francois
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:50:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment