Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39195 )
Change subject: mb/intel/jasperlake_rvp: Add memory config for jslrvp ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 23: = {};
not needed? const is initialized as 0?
Done
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 4: 2019
2019-20
Done
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 35: void
needs board id as arg
Done
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c:
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 5: Copyright 2018 Intel Corp.
2020 since new file.
Done