Attention is currently required from: Ravi kumar, Martin Roth, Paul Menzel, Ravi Kumar Bokka, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 35:
(4 comments)
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/ec38ff14_d461e311 PS6, Line 9: int qclib_soc_blob_load(void)
common code between trogdor and herobrine has been factored into common/. […]
Done
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/cbcb4a85_9e229837 PS22, Line 28: /* Attempt to load Limits Config Blob */ : ssize = fmap_read_area(QCLIB_FR_LIMITS_CFG_DATA, _limits_cfg, : REGION_SIZE(limits_cfg)); : if (ssize < 0) : return -1; : qclib_add_if_table_entry(QCLIB_TE_LIMITS_CFG_DATA, : _limits_cfg, ssize, 0);
We are working on providing a short description of this qclib dependency in the commit message. […]
Ack. Ravi will respond when he gets this information.
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/555dd9be_57546313 PS24, Line 12: ssize_t ssize;
I thought that Julius was asking to only have one size variable (for example ssize_t size) and use i […]
Done
File src/soc/qualcomm/sc7280/timer.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/9cc36be5_9b4fb239 PS6, Line 7: void init_timer(void)
sc7280 doesn't have include/soc/clock.h file at this point in the patch-train. […]
Ack. This file is not available yet. Will modify when the macro is available later on the in patch train.