Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46443 )
Change subject: helpers: add stringification macro ......................................................................
Patch Set 1:
(1 comment)
I'm a bit unsure if this should go into bsd/helpers or just helpers; its not a particularly special bit of code, and its defined twice in coreboot atm, once in src/include/memlayout.ld and src/arch/riscv/include/bits.h under two different licenses.
Everything that can go into bsd/helpers should go there. The other helpers is just for stuff where I wasn't sure it was safe to relicense it to BSD. (For this macro, I think it's trivial enough that it shouldn't be copyrightable.)
https://review.coreboot.org/c/coreboot/+/46443/1/src/commonlib/bsd/include/c... File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/46443/1/src/commonlib/bsd/include/c... PS1, Line 11: #if !defined(STR) && !defined(XSTR) Do we need this extra check? Just remove it from existing uses and have those include this file instead.