Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36273/9/src/lib/Kconfig File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/36273/9/src/lib/Kconfig@27 PS9, Line 27: config RAMSTAGE_CBMEM_TOP_ARG
nit: Does this need a new Kconfig or can we just make the default cbmem_top() implementation __weak and add it unconditionally? (I like to avoid adding boilerplate Kconfigs that every platform from now on will want to select.)
Alternatively, maybe we could turn the logic around and make a CUSTOM_CBMEM_TOP option that all current platforms need to select?
The intend of the Kconfig is more of transitional nature. The idea was to drop it as soon as all platforms used it. Almost all platforms are covered except nvidia SOC which have a custom entry point and MIPS. It's not really clear to me why they have a custom entry point. Any idea if doing the same as on arm and arm64 would work?