Ingo Reitz has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86026?usp=email )
Change subject: mb/google/volteer/drobit> fix power_limits_config ......................................................................
mb/google/volteer/drobit> fix power_limits_config
Drobit showed little power usage and very low clock speeds under load, despite being at very low temperatures. It turns out that power_limits_config was set to the lower end of the dptf power limit ranges as opposed to baseboard and other variants. This seems to prevent the device from using the intended power limits.
Tested: Booted and confirmed correct power usage, clock speeds temperature and stability under 100% load
Change-Id: Id0478c713b51db4972e7d93ec597a30fa885c22b Signed-off-by: Ingo Reitz 9l@9lo.re --- M src/mainboard/google/volteer/variants/drobit/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/86026/1
diff --git a/src/mainboard/google/volteer/variants/drobit/overridetree.cb b/src/mainboard/google/volteer/variants/drobit/overridetree.cb index c791079..148af6e 100644 --- a/src/mainboard/google/volteer/variants/drobit/overridetree.cb +++ b/src/mainboard/google/volteer/variants/drobit/overridetree.cb @@ -12,8 +12,8 @@ register "tcc_offset" = "8"
register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{ - .tdp_pl1_override = 9, - .tdp_pl2_override = 28, + .tdp_pl1_override = 17, + .tdp_pl2_override = 64, .tdp_pl4 = 105, }"