Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49182 )
Change subject: pineview boards: Drop MAINBOARD_HAS_NATIVE_VGA_INIT
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
The native code only supports VGA, which is board dependent. Maybe remove the Kconfig option from the NB instead?
Hmm, TIL. If we ever hit that case, maybe we should just port pineview to libgfxinit instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a30769b4186041a15fd1264bb0d6efa32cb6eb4
Gerrit-Change-Number: 49182
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Jan 2021 17:19:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment