[coreboot-gerrit] Change in coreboot[master]: soc/intel: deduplicate acpi_fill_soc_wake

[Nico Huber (Code Review)]

Attention is currently required from:  Felix Singer, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Duncan Laurie, Angel Pons, Michael Niewöhner, Andrey Petrov, Kyösti Mälkki, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58043 )

Change subject: soc/intel: deduplicate acpi_fill_soc_wake
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/58043/comment/4f096393_7d121048 
PS1, Line 220: RTC_EN
> Yes, sure, but I'm unsure if it should be dropped or not

It's not about the power well. Some of the _EN bits control if a wake
event can be triggered, some don't. In the latter case the wake event
is often always on and the _EN bit just controls SMI/SCI generation.

It's the always on bits that we want to hardcode here. Calling them
by their _EN names makes it confusing because it's not about the actual
register bits (which control something else, see above). It's about
masking _STS bits, hence I would use those names.